Skip to content

fix: preserve primary inference failures and rejection causes - #42

Merged
AppSolves merged 1 commit into
mainfrom
fix/inference-failure-diagnostics
Nov 15, 2026
Merged

AppSolves merged 1 commit into
mainfrom
fix/inference-failure-diagnostics

Conversation

@AppSolves

Copy link
Copy Markdown
Owner

The proxy could overwrite a precise upstream error with a cleanup/pipeline error and falsely report provider_stream_failed when Codex closed HTTP after a valid response.completed. Engine output normalization also hid why an otherwise completed turn could not become a valid review.

Preserve a bounded per-request start/finish record with independent primary/cleanup failures, HTTP/SSE metadata and allowlisted transport codes. Success clears recovered errors; older requests cannot replace a newer one. The Docker host forwards only sanitized recent failures and final request state. Add fixed engine rejection reasons without exposing model text. All failed/incomplete analysis still fails CI and remains non-approving.

Validation: npm run check (216 tests), clean checkout, workerd/D1, browser suite, model catalog, npm audit (zero vulnerabilities), Actionlint, Wrangler dry-run, Docker build and actual pinned Codex sandbox. Native regressions cover clean/incomplete responses whose HTTP body stays open and schema/JSON-invalid output. Provider responses are synthetic; no live inference.

No prompt, model, inference timeout, context budget, authorization, credential, quota or merge-policy changes. The source config temporarily closes the merge gate for the established immutable pin rollout; restore it only after caller/Worker coordination. No database migration or new production review is required.

@AppSolves
AppSolves enabled auto-merge (squash) November 15, 2026 17:44
@AppSolves
AppSolves disabled auto-merge November 15, 2026 17:44
@AppSolves
AppSolves merged commit a6a5ceb into main Nov 15, 2026
4 checks passed
@AppSolves
AppSolves deleted the fix/inference-failure-diagnostics branch November 15, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant